support ssl for flink connector #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #36 +/- ##
============================================
+ Coverage 39.62% 39.68% +0.05%
- Complexity 145 152 +7
============================================
Files 46 48 +2
Lines 1398 1469 +71
Branches 132 136 +4
============================================
+ Hits 554 583 +29
- Misses 791 833 +42
Partials 53 53
Continue to review full report at Codecov.
|
HarrisChu
reviewed
Nov 18, 2021
|
|
||
| private final SelfSignedSSLParam selfSignParam; | ||
| private final SelfSignParams selfSignParams; |
There was a problem hiding this comment.
one with SSL and another with not ?
There was a problem hiding this comment.
I'll fix the caSSLSignParams to caSignParams.
HarrisChu
approved these changes
Nov 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.